Adds export functionality to chat, removes poetry in favor of uv, bumps Honcho version to v0.0.14/python-SDK-0.0.19
#15
Conversation
Deploying yousim with
|
| Latest commit: |
b678112
|
| Status: | 🚫 Build failed. |
bLopata
changed the title
export functionality to chat, removes poetry in favor of uv.export functionality to chat, removes poetry in favor of uv, bumps Honcho version to v0.0.14/python-SDK-0.0.19
| ] | ||
|
|
||
| # Create a temporary file | ||
| with tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.json') as tmp: |
There was a problem hiding this comment.
is writing to disk necessary here? i feel like this could be done in memeory
There was a problem hiding this comment.
or is this already in memory? i've never used this library before, if so, neat trick.
There was a problem hiding this comment.
From python docs
tempfile.TemporaryFile(mode='w+b', buffering=-1, encoding=None, newline=None, suffix=None, prefix=None, dir=None, *, errors=None) Return a [file-like object](https://docs.python.org/3/glossary.html#term-file-like-object) that can be used as a temporary storage area. The file is created securely, using the same rules as [mkstemp()](https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp). It will be destroyed as soon as it is closed (including an implicit close when the object is garbage collected). Under Unix, the directory entry for the file is either not created at all or is removed immediately after the file is created. Other platforms do not support this; your code should not rely on a temporary file created using this function having or not having a visible name in the file system.
|
|
||
| services: | ||
| backend: | ||
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| ports: | ||
| - "8000:8000" | ||
| - "${PORT}:${PORT}" |
There was a problem hiding this comment.
why do we care about the port within the container?
There was a problem hiding this comment.
I made this more complicated than needed because I was running my honcho fastAPI on (the default) port 8000, so I was specifying here to avoid any problems. I will fix this.
| @@ -1,23 +1,25 @@ | |||
| [tool.poetry] | |||
There was a problem hiding this comment.
good riddance haha, uv supremacy
| RUN npm run build | ||
|
|
||
| # Expose the port the app runs on | ||
| # Use development server |
There was a problem hiding this comment.
should we use a dev server in this case?
There was a problem hiding this comment.
The docker container is really used for development. In production we are just serving the static front end. the dev server is really just to make it easy to serve locally
Solves dev-552, dev-494, dev-561